Message-ID: <1412367858.13320.432.camel@snotra.buserror.net>
Subject: Re: [PATCH 2/2] spi: fsl-spi: Allow dynamic allocation of CPM1
 parameter RAM
From: Scott Wood <scottwood@freescale.com>
To: christophe leroy <christophe.leroy@c-s.fr>
CC: Mark Brown <broonie@kernel.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        "Marcelo Tosatti" <marcelo@kvack.org>,
        Vitaly Bordug <vitb@kernel.crashing.org>,
        <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        <linux-spi@vger.kernel.org>,
        Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Fri, 3 Oct 2014 15:24:18 -0500
In-Reply-To: <542F03CF.8010900@c-s.fr>
References: <20141003125609.5BEA11AB276@localhost.localdomain>
	 <20141003144420.GC24441@sirena.org.uk> <542F03CF.8010900@c-s.fr>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 2014-10-03 at 22:15 +0200, christophe leroy wrote:
> Le 03/10/2014 16:44, Mark Brown a écrit :
> > On Fri, Oct 03, 2014 at 02:56:09PM +0200, Christophe Leroy wrote:
> >
> >> +config CPM1_RELOCSPI
> >> +	bool "Dynamic SPI relocation"
> >> +	default n
> >> +	help
> >> +	  On recent MPC8xx (at least MPC866 and MPC885) SPI can be relocated
> >> +	  without micropatch. This activates relocation to a dynamically
> >> +	  allocated area in the CPM Dual port RAM.
> >> +	  When combined with SPI relocation patch (for older MPC8xx) it avoids
> >> +	  the "loss" of additional Dual port RAM space just above the patch,
> >> +	  which might be needed for example when using the CPM QMC.
> > Something like this shouldn't be a compile time option.  Either it
> > should be unconditional or it should be triggered in some system
> > specific manner (from DT, from knowing about other users or similar).
> Can't be unconditional as older versions of mpc8xx (eg MPC860) don't 
> support relocation without a micropatch.
> I have therefore submitted a v2 based on a DTS compatible property.

So the device tree change is about whether relocation is supported, not
whether it is required?  Is this specific to SPI or does the relocation
mechanism work for other things?

How about checking for the existing specific-SoC compatibles?

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/