Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbaJDM4S (ORCPT ); Sat, 4 Oct 2014 08:56:18 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58157 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbaJDM4Q (ORCPT ); Sat, 4 Oct 2014 08:56:16 -0400 Message-ID: <542FEE6F.4090907@kernel.org> Date: Sat, 04 Oct 2014 13:56:15 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Daniel Baluta , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org CC: irina.tirdea@intel.com Subject: Re: [RFC PATCH 6/8] iio: core: Introduce new STEP_DETECT event References: <1412257439-15683-1-git-send-email-daniel.baluta@intel.com> <1412257439-15683-7-git-send-email-daniel.baluta@intel.com> In-Reply-To: <1412257439-15683-7-git-send-email-daniel.baluta@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/14 14:43, Daniel Baluta wrote: > From: Irina Tirdea > > This event is needed for the step detection functionality of a pedometer: > an interrupt is generated by the hardware device each time > a step is detected. > > To support this, we add a new iio event. > > For more information on the pedometer requirements for Android see > http://source.android.com/devices/sensors/composite_sensors.html#detector. > > A device that has the pedometer functionality this interface needs to > support is Freescale's MMA9553L: > http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf > > Signed-off-by: Irina Tirdea > Signed-off-by: Daniel Baluta This could be more generic. Perhaps an 'instance' event? If applied to our step type it would be in_step_instance_en etc? > --- > Documentation/ABI/testing/sysfs-bus-iio | 7 +++++++ > drivers/iio/industrialio-event.c | 1 + > include/linux/iio/types.h | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index c02785d..fd66073 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -815,6 +815,13 @@ Description: > Enables or disables motion detection. Each time motion is detected an > event of this type will be generated. > > +What: /sys/.../events/in_activity_step_detect_either_en > +KernelVersion: 3.17 > +Contact: linux-iio@vger.kernel.org > +Description: > + Enables or disables step detection. Each time the user takes a step an > + event of this type will be generated. > + > What: /sys/bus/iio/devices/iio:deviceX/trigger/current_trigger > KernelVersion: 2.6.35 > Contact: linux-iio@vger.kernel.org > diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c > index eca5af2..c2ade1f 100644 > --- a/drivers/iio/industrialio-event.c > +++ b/drivers/iio/industrialio-event.c > @@ -198,6 +198,7 @@ static const char * const iio_ev_type_text[] = { > [IIO_EV_TYPE_THRESH_ADAPTIVE] = "thresh_adaptive", > [IIO_EV_TYPE_MAG_ADAPTIVE] = "mag_adaptive", > [IIO_EV_TYPE_MOTION] = "motion", > + [IIO_EV_TYPE_STEP_DETECT] = "step_detect", > }; > > static const char * const iio_ev_dir_text[] = { > diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h > index ae51780..83768a6 100644 > --- a/include/linux/iio/types.h > +++ b/include/linux/iio/types.h > @@ -75,6 +75,7 @@ enum iio_event_type { > IIO_EV_TYPE_THRESH_ADAPTIVE, > IIO_EV_TYPE_MAG_ADAPTIVE, > IIO_EV_TYPE_MOTION, > + IIO_EV_TYPE_STEP_DETECT, > }; > > enum iio_event_info { > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/