Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbaJFJ1m (ORCPT ); Mon, 6 Oct 2014 05:27:42 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:42913 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbaJFJ1h (ORCPT ); Mon, 6 Oct 2014 05:27:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <1411367422-2095-1-git-send-email-ssreedharan@mvista.com> Date: Mon, 6 Oct 2014 14:57:37 +0530 Message-ID: Subject: Re: [PATCH] serial/core: Initialize the console pm state From: Sudhir Sreedharan To: Kevin Hilman Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jslaby@suse.cz, lkml , olof@lixom.net, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, On Wed, Oct 1, 2014 at 10:57 PM, Kevin Hilman wrote: > On Sun, Sep 21, 2014 at 11:30 PM, Sudhir Sreedharan > wrote: >> For console devices having UART_CAP_SLEEP capability, the uart_pm_state has >> to be initialized to UART_PM_STATE_ON. Otherwise the LCR regiser values >> are reinitialized when uart_change_pm is called from uart_configure_port. >> >> Signed-off-by: Sudhir Sreedharan > > Multiple boot failures on ARM[1] were bisected down to this patch. > > How was this patch tested, and on which platforms? This patch was tested on x86-64(haswell) board, which uses ST16650V2 uart(which has UART_CAP_SLEEP). While serial driver gets initialized, console port LCR register is getting reinitalized to 0. Then boot logs will be seen as garbage characters. I will re-check why this failed on the boards/archs you mentioned. Thanks, Sudhir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/