Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbaJFLRP (ORCPT ); Mon, 6 Oct 2014 07:17:15 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:62870 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbaJFLRM (ORCPT ); Mon, 6 Oct 2014 07:17:12 -0400 MIME-Version: 1.0 In-Reply-To: <542FECB4.5010001@kernel.org> References: <1412257439-15683-1-git-send-email-daniel.baluta@intel.com> <1412257439-15683-2-git-send-email-daniel.baluta@intel.com> <542FECB4.5010001@kernel.org> Date: Mon, 6 Oct 2014 14:17:11 +0300 X-Google-Sender-Auth: KhDCki-MkSLwVUqjR5qTotmO8j8 Message-ID: Subject: Re: [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device From: Daniel Baluta To: Jonathan Cameron Cc: Daniel Baluta , linux-iio@vger.kernel.org, Linux Kernel Mailing List , irina.tirdea@intel.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 4, 2014 at 3:48 PM, Jonathan Cameron wrote: > On 02/10/14 14:43, Daniel Baluta wrote: >> We need a way to store events generated by iio_dummy_evgen module, >> in order to correctly process IRQs in iio_simple_dummy_events. >> >> For the moment, we add two registers: >> >> * id_reg - ID register, stores the source of the event >> * id_data - DATA register, stores the type of the event >> >> e.g echo 4 > /sys/bus/iio/devices/iio_evgen/poke2 >> >> id_reg 0x02, id_data 0x04 >> >> This means, event of type 4 was generated by fake device 2. >> >> We currently use a hardcoded mapping of virtual events to IIO events. >> >> Signed-off-by: Daniel Baluta >> Signed-off-by: Irina Tirdea > Does the job and will look enough like a normal interrupt that > it allows the dummy driver to act as example code. Hi Jonathan, Thanks for the reviews. This patch is self contained and it could be merged separately if you think it's stable enough. We are going over your reviews for the other patches and will send v2 as soon as possible. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/