Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbaJFLdi (ORCPT ); Mon, 6 Oct 2014 07:33:38 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:35400 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaJFLdd (ORCPT ); Mon, 6 Oct 2014 07:33:33 -0400 Date: Mon, 6 Oct 2014 12:33:26 +0100 From: Mark Rutland To: Thierry Reding Cc: Boris Brezillon , David Airlie , "dri-devel@lists.freedesktop.org" , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Samuel Ortiz , Lee Jones , "linux-pwm@vger.kernel.org" , Rob Clark , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Yao Subject: Re: [PATCH v7 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver Message-ID: <20141006113326.GG24686@leverpostej> References: <1412175188-28278-1-git-send-email-boris.brezillon@free-electrons.com> <1412175188-28278-5-git-send-email-boris.brezillon@free-electrons.com> <20141006101350.GD25202@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141006101350.GD25202@ulmo> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 06, 2014 at 11:13:51AM +0100, Thierry Reding wrote: > On Wed, Oct 01, 2014 at 04:53:01PM +0200, Boris Brezillon wrote: > > From: Boris BREZILLON > > > > The HLCDC IP available in some Atmel SoCs (i.e. sam9x5i.e. at91sam9n12, > > at91sam9x5 family or sama5d3 family) provide a PWM device. > > > > The DT bindings used for this PWM device is following the default 3 cells > > bindings described in Documentation/devicetree/bindings/pwm/pwm.txt. > > > > Signed-off-by: Boris Brezillon > > --- > > .../devicetree/bindings/pwm/atmel-hlcdc-pwm.txt | 55 ++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > new file mode 100644 > > index 0000000..86ad3e2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > @@ -0,0 +1,55 @@ > > +Device-Tree bindings for Atmel's HLCDC (High LCD Controller) PWM driver > > + > > +The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > > +See ../mfd/atmel-hlcdc.txt for more details. > > + > > +Required properties: > > + - compatible: value should be one of the following: > > + "atmel,hlcdc-pwm" > > + - pinctr-names: the pin control state names. Should contain "default". > > + - pinctrl-0: should contain the pinctrl states described by pinctrl > > + default. > > + - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > > + bindings defined in Documentation/devicetree/bindings/pwm/pwm.txt. > > + The first cell encodes the PWM id (0 is the only acceptable value here, > > + because the chip only provide one PWM). > > + The second cell encodes the PWM period in nanoseconds. > > + The third cell encodes the PWM flags (the only supported flag is > > + PWM_POLARITY_INVERTED) > > Given that this already refers to the default 3 cells binding it doesn't > need to repeat part of the contents of pwm.txt. Given that pwm.txt states: pwm-specifier : array of #pwm-cells specifying the given PWM (controller specific) I'd leave it here. Just because pwm.txt gives an example of a controller specific meaning for the pwm cells, I don't think we should rely on it everywhere. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/