Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbaJFMZp (ORCPT ); Mon, 6 Oct 2014 08:25:45 -0400 Received: from top.free-electrons.com ([176.31.233.9]:55395 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752160AbaJFMZn (ORCPT ); Mon, 6 Oct 2014 08:25:43 -0400 Date: Mon, 6 Oct 2014 14:25:38 +0200 From: Boris Brezillon To: Thierry Reding Cc: David Airlie , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Samuel Ortiz , Lee Jones , linux-pwm@vger.kernel.org, Rob Clark , linux-arm-kernel@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Yao Subject: Re: [PATCH v7 10/11] ARM: at91/dt: add LCD panel description to sama5d3xdm.dtsi Message-ID: <20141006142538.76d2df29@bbrezillon> In-Reply-To: <20141006110115.GH25202@ulmo> References: <1412175188-28278-1-git-send-email-boris.brezillon@free-electrons.com> <1412175188-28278-11-git-send-email-boris.brezillon@free-electrons.com> <20141006110115.GH25202@ulmo> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Oct 2014 13:01:16 +0200 Thierry Reding wrote: > On Wed, Oct 01, 2014 at 04:53:07PM +0200, Boris Brezillon wrote: > [...] > > diff --git a/arch/arm/boot/dts/sama5d3xdm.dtsi b/arch/arm/boot/dts/sama5d3xdm.dtsi > [...] > > + bl_reg: backlight_regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "backlight-power-supply"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + status = "disabled"; > > + }; > > + > > + panel_reg: panel_regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "panel-power-supply"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + status = "disabled"; > > + }; > > + > > + backlight: backlight { > > + compatible = "pwm-backlight"; > > + pwms = <&hlcdc_pwm 0 50000 0>; > > + brightness-levels = <0 4 8 16 32 64 128 255>; > > + default-brightness-level = <6>; > > + power-supply = <&bl_reg>; > > + status = "disabled"; > > + }; > > Why are these all disabled? Patch 11/11 now needs to enable all of them > explicitly for each board that uses this display module. Yes, these nodes should be enabled. I just thought we could include the xdm dtsi and enable what we really need in the board file, but it doesn't make any sense... > > > + panel: panel { > > + compatible = "foxlink,fl500wvr00-a0t", "simple-panel"; > > "simple-panel" shouldn't be in this list. There's nothing useful a > driver can do by matching on it. Sure, I'll remove the "simple-panel" compatible string. > > > + backlight = <&backlight>; > > + power-supply = <&panel_reg>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + > > + port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + panel_input: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&hlcdc_panel_output>; > > + }; > > }; > > There's no support for OF graphs in simple-panel, so this is unused, > isn't it? Actually I use it in my atmel_hlcdc_ouput implementation to figure out the link between a panel and a device connected on the RGB/DPI bus. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/