Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbaJFM7T (ORCPT ); Mon, 6 Oct 2014 08:59:19 -0400 Received: from top.free-electrons.com ([176.31.233.9]:55604 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752428AbaJFM7R (ORCPT ); Mon, 6 Oct 2014 08:59:17 -0400 Date: Mon, 6 Oct 2014 14:59:12 +0200 From: Boris Brezillon To: Thierry Reding Cc: David Airlie , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor , Samuel Ortiz , Lee Jones , linux-pwm@vger.kernel.org, Rob Clark , linux-arm-kernel@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Yao Subject: Re: [PATCH v7 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver Message-ID: <20141006145912.1e448507@bbrezillon> In-Reply-To: <20141006101350.GD25202@ulmo> References: <1412175188-28278-1-git-send-email-boris.brezillon@free-electrons.com> <1412175188-28278-5-git-send-email-boris.brezillon@free-electrons.com> <20141006101350.GD25202@ulmo> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Oct 2014 12:13:51 +0200 Thierry Reding wrote: > On Wed, Oct 01, 2014 at 04:53:01PM +0200, Boris Brezillon wrote: > > From: Boris BREZILLON > > > > The HLCDC IP available in some Atmel SoCs (i.e. sam9x5i.e. at91sam9n12, > > at91sam9x5 family or sama5d3 family) provide a PWM device. > > > > The DT bindings used for this PWM device is following the default 3 cells > > bindings described in Documentation/devicetree/bindings/pwm/pwm.txt. > > > > Signed-off-by: Boris Brezillon > > --- > > .../devicetree/bindings/pwm/atmel-hlcdc-pwm.txt | 55 ++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > new file mode 100644 > > index 0000000..86ad3e2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > @@ -0,0 +1,55 @@ > > +Device-Tree bindings for Atmel's HLCDC (High LCD Controller) PWM driver > > + > > +The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > > +See ../mfd/atmel-hlcdc.txt for more details. > > + > > +Required properties: > > + - compatible: value should be one of the following: > > + "atmel,hlcdc-pwm" > > + - pinctr-names: the pin control state names. Should contain "default". > > + - pinctrl-0: should contain the pinctrl states described by pinctrl > > + default. > > + - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > > + bindings defined in Documentation/devicetree/bindings/pwm/pwm.txt. > > + The first cell encodes the PWM id (0 is the only acceptable value here, > > + because the chip only provide one PWM). > > + The second cell encodes the PWM period in nanoseconds. > > + The third cell encodes the PWM flags (the only supported flag is > > + PWM_POLARITY_INVERTED) > > Given that this already refers to the default 3 cells binding it doesn't > need to repeat part of the contents of pwm.txt. > > With that fixed and assuming you'd like this to be merged via the same > tree that the DRM and or MFD driver is, this patch: > > Acked-by: Thierry Reding > > If you'd prefer this to go through the PWM tree just let me know. Yes I'd prefer this solution, but shouldn't we wait for Lee to take the first two patches in his tree ? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/