Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbaJFPQ2 (ORCPT ); Mon, 6 Oct 2014 11:16:28 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56843 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222AbaJFPQY (ORCPT ); Mon, 6 Oct 2014 11:16:24 -0400 Date: Mon, 6 Oct 2014 17:16:14 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Sudeep Dutt , Ashutosh Dixit , Greg Kroah-Hartman , Nikhil Rao , Siva Yerramreddy , Wolfram Sang , Heinz Graalfs , linux-s390@vger.kernel.org Subject: Re: [PATCH v2 02/15] virtio: unify config_changed handling Message-ID: <20141006171614.376ba255.cornelia.huck@de.ibm.com> In-Reply-To: <1412608214-31944-3-git-send-email-mst@redhat.com> References: <1412608214-31944-1-git-send-email-mst@redhat.com> <1412608214-31944-3-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100615-3548-0000-0000-000001C53FBC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Oct 2014 18:10:44 +0300 "Michael S. Tsirkin" wrote: > Replace duplicated code in all transports with a single wrapper in > virtio.c. > > The only functional change is in virtio_mmio.c: if a buggy device sends > us an interrupt before driver is set, we previously returned IRQ_NONE, > now we return IRQ_HANDLED. > > As this must not happen in practice, this does not look like a big deal. > > See also commit 3fff0179e33cd7d0a688dab65700c46ad089e934 > virtio-pci: do not oops on config change if driver not loaded. > for the original motivation behind the driver check. > > Signed-off-by: Michael S. Tsirkin > --- > include/linux/virtio.h | 2 ++ > drivers/misc/mic/card/mic_virtio.c | 6 +----- > drivers/s390/kvm/kvm_virtio.c | 9 +-------- > drivers/s390/kvm/virtio_ccw.c | 6 +----- > drivers/virtio/virtio.c | 9 +++++++++ > drivers/virtio/virtio_mmio.c | 7 ++----- > drivers/virtio/virtio_pci.c | 6 +----- > 7 files changed, 17 insertions(+), 28 deletions(-) Reviewed-by: Cornelia Huck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/