Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbaJFPex (ORCPT ); Mon, 6 Oct 2014 11:34:53 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:50563 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbaJFPew (ORCPT ); Mon, 6 Oct 2014 11:34:52 -0400 Date: Mon, 6 Oct 2014 17:34:39 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core Message-ID: <20141006173439.6baf1b35.cornelia.huck@de.ibm.com> In-Reply-To: <20141006152655.GA32277@redhat.com> References: <1412608214-31944-1-git-send-email-mst@redhat.com> <1412608214-31944-4-git-send-email-mst@redhat.com> <20141006172055.6fd0fa20.cornelia.huck@de.ibm.com> <20141006152655.GA32277@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100615-8372-0000-0000-0000016E2EFC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Oct 2014 18:26:55 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 06, 2014 at 05:20:55PM +0200, Cornelia Huck wrote: > > On Mon, 6 Oct 2014 18:10:51 +0300 > > "Michael S. Tsirkin" wrote: > > > > > This is in preparation to extending config changed event handling > > > in core. > > > Wrapping these in an API also seems to make for a cleaner code. > > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > include/linux/virtio.h | 6 +++++ > > > drivers/virtio/virtio.c | 53 +++++++++++++++++++++++++++++++++++++++++++ > > > drivers/virtio/virtio_pci.c | 55 ++------------------------------------------- > > > 3 files changed, 61 insertions(+), 53 deletions(-) > > > > > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > > > index 3c19bd3..8df7ba8 100644 > > > --- a/include/linux/virtio.h > > > +++ b/include/linux/virtio.h > > > @@ -78,6 +78,7 @@ bool virtqueue_is_broken(struct virtqueue *vq); > > > /** > > > * virtio_device - representation of a device using virtio > > > * @index: unique position on the virtio bus > > > + * @failed: saved value for CONFIG_S_FAILED bit (for restore) > > > > Have you considered s/failed/saved_failed/ ? > > I kind of prefer the shorter name, your reviewed tag made me think > you don't cosider this too important? Indeed; if you prefer the short name, just keep it. > > > > * @dev: underlying device. > > > * @id: the device type identification (used to match it with a driver). > > > * @config: the configuration ops for this device. > > > > Otherwise, my > > > > Reviewed-by: Cornelia Huck > > > > still stands. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/