Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 6 Dec 2002 13:49:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 6 Dec 2002 13:49:45 -0500 Received: from poup.poupinou.org ([195.101.94.96]:28681 "EHLO poup.poupinou.org") by vger.kernel.org with ESMTP id ; Fri, 6 Dec 2002 13:49:45 -0500 Date: Fri, 6 Dec 2002 19:57:02 +0100 To: Pavel Machek Cc: Patrick Mochel , kernel list , ACPI mailing list Subject: Re: [ACPI] Re: [2.5.50, ACPI] link error Message-ID: <20021206185702.GE17595@poup.poupinou.org> References: <20021205224019.GH7396@atrey.karlin.mff.cuni.cz> <20021206000618.GB15784@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021206000618.GB15784@atrey.karlin.mff.cuni.cz> User-Agent: Mutt/1.4i From: Ducrot Bruno Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 38 On Fri, Dec 06, 2002 at 01:06:18AM +0100, Pavel Machek wrote: > Hi! > > > > > Doesn't that imply your fix is broken to begin with? > > > > > > ACPI/S4 support needs swsusp. ACPI/S3 needs big part of > > > swsusp. Splitting CONFIG_ACPI_SLEEP to S3 and S4 part seems like > > > overdesign to me, OTOH if you do the work it is okay with me. > > > > You broke the design. S3 support was developed long before swsusp was in > > the kernel, and completely indpendent of it. It should have remained that > > way. > > > > S3 support is a subset of what is need for S4 support. > > That's not true. acpi_wakeup.S is nasty piece of code, needed for S3 > but not for S4. Big part of driver support is only needed for S3. > > > swsusp is an implementation of S4 support. In theory, there could be > > multiple implementations that all use the same core (saving/restoring > > state). > > There were patches for S4bios floating around, but it never really > worked, IIRC. No. It work. I do not resubmmited patches because I think that swsusp is better. -- Ducrot Bruno -- Which is worse: ignorance or apathy? -- Don't know. Don't care. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/