Message-ID: <1412730192.3438.19.camel@joe-AO725>
Subject: Re: [PATCH] staging: rtl8712: fix unnecessary elses after
 return/break in rtl8712_efuse.c
From: Joe Perches <joe@perches.com>
To: Serguey Parkhomovsky <sergueyparkhomovsky@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Tue, 07 Oct 2014 18:03:12 -0700
In-Reply-To: <20141007234823.GA25549@fedora.localdomain>
References: <20141007234823.GA25549@fedora.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-10-07 at 16:48 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -414,19 +414,19 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
[]
> +		/* call rescue procedure */
> +		if (fix_header(padapter, efuse_data, efuse_addr) ==
> +		    false)
> +			return false; /* rescue fail */

Probably better as:

		if (!fix_header(padapter, efuse_data, efuse_addr))
			return false;	/* rescue fail */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/