Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755714AbaJHKZt (ORCPT ); Wed, 8 Oct 2014 06:25:49 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:38841 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755000AbaJHKZr (ORCPT ); Wed, 8 Oct 2014 06:25:47 -0400 MIME-Version: 1.0 In-Reply-To: References: <1412667049-6128-1-git-send-email-pramod.gurav@smartplayin.com> <20141007163856.GE16469@dtor-ws> Date: Wed, 8 Oct 2014 15:55:45 +0530 Message-ID: Subject: Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path From: Pramod Gurav To: Dmitry Torokhov Cc: Pramod Gurav , "linux-kernel@vger.kernel.org" , Michael Hennerich , linux-input@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 8, 2014 at 3:48 PM, Pramod Gurav wrote: > Hi Dmitry, > > On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov > .. > Thanks. I saw the change in your tree. Shouldn't > cancel_delayed_work_sync(&kpad->work) be called under label > err_free_mem so that it will executed in case adp5588_read, > input_register_device, request_irq etc. > Or else we will still have workqueue instance hanging around. > Sorry, Should have read Michael's reply more carefully. I get the reason behind cancelling workquequq after freeing irq. -- Thanks and Regards Pramod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/