Date: Wed, 8 Oct 2014 12:49:20 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Matt Fleming <matt.fleming@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 06/11] perf: Move cgroup init before PMU ->event_init()
Message-ID: <20141008104920.GI10832@worktop.programming.kicks-ass.net>
References: <1411567455-31264-1-git-send-email-matt@console-pimps.org>
 <1411567455-31264-7-git-send-email-matt@console-pimps.org>
 <20141007193424.GB4750@worktop.programming.kicks-ass.net>
 <20141008103250.GO14343@console-pimps.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141008103250.GO14343@console-pimps.org>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Oct 08, 2014 at 11:32:50AM +0100, Matt Fleming wrote:
> On Tue, 07 Oct, at 09:34:24PM, Peter Zijlstra wrote:
> > On Wed, Sep 24, 2014 at 03:04:10PM +0100, Matt Fleming wrote:
> > > +++ b/kernel/events/core.c
> > > @@ -6859,7 +6859,7 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
> > >  		 struct perf_event *group_leader,
> > >  		 struct perf_event *parent_event,
> > >  		 perf_overflow_handler_t overflow_handler,
> > > -		 void *context)
> > > +		 void *context, bool cgroup, pid_t pid)
> > >  {
> > >  	struct pmu *pmu;
> > >  	struct perf_event *event;
> > 
> > I don't get this extension, why a bool and pid_t ?
> 
> So that it's possible to figure out whether we need to call
> perf_cgroup_connect(). 
> 
> Oh, why not just 'int fd', you mean? Ermm... yeah that would be better.

Jah ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/