Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756200AbaJHL3g (ORCPT ); Wed, 8 Oct 2014 07:29:36 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:62167 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059AbaJHL3e (ORCPT ); Wed, 8 Oct 2014 07:29:34 -0400 MIME-Version: 1.0 In-Reply-To: <1412760595-3935-19-git-send-email-lftan@altera.com> References: <1412760595-3935-1-git-send-email-lftan@altera.com> <1412760595-3935-19-git-send-email-lftan@altera.com> Date: Wed, 8 Oct 2014 13:29:33 +0200 Message-ID: Subject: Re: [PATCH v4 18/29] nios2: Signal handling support From: Richard Weinberger To: Ley Foon Tan Cc: Linux-Arch , LKML , "linux-doc@vger.kernel.org" , Arnd Bergmann , LeyFoon Tan , cltang@codesourcery.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 8, 2014 at 11:29 AM, Ley Foon Tan wrote: > This patch adds support for signal handling. > > Signed-off-by: Ley Foon Tan Maybe I'm misreading your code but where do you check for multiple pending signals? It looks like you're handling only exact one signal before retuning to userspace. This is a serious issue, if you post a SIGSEGV i.e. in do_rt_sigreturn() you need to handle it later instead of directly returning to userspace. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/