Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbaJHTkG (ORCPT ); Wed, 8 Oct 2014 15:40:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34362 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbaJHTkD (ORCPT ); Wed, 8 Oct 2014 15:40:03 -0400 Date: Wed, 8 Oct 2014 21:36:44 +0200 From: Oleg Nesterov To: Peter Zijlstra Cc: Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Kirill Tkhai Subject: [PATCH v2 1/2] sched: schedule_tail() should disable preemption Message-ID: <20141008193644.GA32055@redhat.com> References: <20141007195046.GA28002@redhat.com> <20141008080016.GB10832@worktop.programming.kicks-ass.net> <20141008183302.GA17495@redhat.com> <20141008183326.GB17495@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141008183326.GB17495@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08, Oleg Nesterov wrote: > > Another problem is that finish_task_switch() itself runs with preempt > enabled after finish_lock_switch(). If nothing else this means that > ->sched_in() notifier can't trust its "cpu" arg. OOPS, this obviously can't happen, ->preempt_notifiers must be empty. Remove this part from the changelog, please see v2. I am not sure about finish_arch_post_lock_switch() ... but probably it should be fine without preempt_disable. ------------------------------------------------------------------------------- Subject: [PATCH v2 1/2] sched: schedule_tail() should disable preemption finish_task_switch() enables preemption, so post_schedule(rq) can be called on the wrong (and even dead) CPU. Afaics, nothing really bad can happen, but in this case we can wrongly clear rq->post_schedule on that CPU. And this simply looks wrong in any case. Signed-off-by: Oleg Nesterov --- kernel/sched/core.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 703c7e6..3f267e8 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2277,15 +2277,14 @@ static inline void post_schedule(struct rq *rq) asmlinkage __visible void schedule_tail(struct task_struct *prev) __releases(rq->lock) { - struct rq *rq = this_rq(); + struct rq *rq; + /* finish_task_switch() drops rq->lock and enables preemtion */ + preempt_disable(); + rq = this_rq(); finish_task_switch(rq, prev); - - /* - * FIXME: do we need to worry about rq being invalidated by the - * task_switch? - */ post_schedule(rq); + preempt_enable(); if (current->set_child_tid) put_user(task_pid_vnr(current), current->set_child_tid); -- 1.5.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/