Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754767AbaJHX3n (ORCPT ); Wed, 8 Oct 2014 19:29:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:47501 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbaJHX3e (ORCPT ); Wed, 8 Oct 2014 19:29:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,681,1406617200"; d="scan'208";a="611610730" Message-ID: <1412810962.28467.69.camel@acox1-desk.ger.corp.intel.com> Subject: Re: [PATCH 03/12] serial_core: Handle TIOC[GS]RS485 ioctls. From: Alan Cox To: Ricardo Ribalda Delgado Cc: One Thousand Gnomes , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , LKML Date: Thu, 09 Oct 2014 00:29:22 +0100 In-Reply-To: References: <1412798258-23655-1-git-send-email-ricardo.ribalda@gmail.com> <1412798258-23655-4-git-send-email-ricardo.ribalda@gmail.com> <1412799101.28467.68.camel@acox1-desk.ger.corp.intel.com> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-10-08 at 22:43 +0200, Ricardo Ribalda Delgado wrote: > Hello Alan > > This patchset adds no extra locking features, if the drivers did not > implement a locking mechanism (and none did) there is chance of > conflict. > > I can add a call to lock/unlock around uart_[gs]et_rs485_config. And > then, inside the drivers, use the lock when the structure is used. > > I would prefer to add it as new patches in the patchset, so in case > this adds some bugs they can be bisected easily. Makes sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/