Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbaJIIeH (ORCPT ); Thu, 9 Oct 2014 04:34:07 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:39861 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754804AbaJIIdt (ORCPT ); Thu, 9 Oct 2014 04:33:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1412760595-3935-1-git-send-email-lftan@altera.com> <1412760595-3935-19-git-send-email-lftan@altera.com> Date: Thu, 9 Oct 2014 16:33:46 +0800 X-Google-Sender-Auth: Z-_1Iz_V6jUObHZR7okIJA7b3fg Message-ID: Subject: Re: [PATCH v4 18/29] nios2: Signal handling support From: Ley Foon Tan To: Richard Weinberger Cc: Linux-Arch , LKML , "linux-doc@vger.kernel.org" , Arnd Bergmann , Chung-Lin Tang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 8, 2014 at 7:29 PM, Richard Weinberger wrote: > On Wed, Oct 8, 2014 at 11:29 AM, Ley Foon Tan wrote: >> This patch adds support for signal handling. >> >> Signed-off-by: Ley Foon Tan > > Maybe I'm misreading your code but where do you check for multiple > pending signals? > It looks like you're handling only exact one signal before retuning to > userspace. > This is a serious issue, if you post a SIGSEGV i.e. in > do_rt_sigreturn() you need to handle it later > instead of directly returning to userspace. Yes, Al also pointing out this. Will update this. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/