Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095AbaJIIiw (ORCPT ); Thu, 9 Oct 2014 04:38:52 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:34779 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbaJIIit (ORCPT ); Thu, 9 Oct 2014 04:38:49 -0400 MIME-Version: 1.0 In-Reply-To: <20141009074729.GN3279@distanz.ch> References: <1412760595-3935-1-git-send-email-lftan@altera.com> <1412760595-3935-18-git-send-email-lftan@altera.com> <20141009074729.GN3279@distanz.ch> Date: Thu, 9 Oct 2014 16:38:47 +0800 X-Google-Sender-Auth: PioLC7S8Q9WnhALFeZwvKOyieNM Message-ID: Subject: Re: [PATCH v4 17/29] nios2: System calls handling From: Ley Foon Tan To: Tobias Klauser Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Arnd Bergmann , Chung-Lin Tang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 9, 2014 at 3:47 PM, Tobias Klauser wrote: >> +#if defined(CONFIG_FB) || defined(CONFIG_FB_MODULE) >> +#include >> +unsigned long get_fb_unmapped_area(struct file *filp, unsigned long orig_addr, >> + unsigned long len, unsigned long pgoff, unsigned long flags) >> +{ >> + >> + struct fb_info *info = filp->private_data; >> + >> + return (unsigned long)info->screen_base; >> +} >> +EXPORT_SYMBOL(get_fb_unmapped_area); > > get_fb_unmapped_area only used if HAVE_ARCH_FB_UNMAPPED_AREA is defined, > but this isn't the case for nios2. AFAICS the altfb driver has been > broken on nios2 for a long time anyway, so I'd suggest to just remove > this function for now. Okay. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/