Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757257AbaJINqM (ORCPT ); Thu, 9 Oct 2014 09:46:12 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:40135 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbaJINqB (ORCPT ); Thu, 9 Oct 2014 09:46:01 -0400 From: Sudhir Sreedharan To: gregkh@linuxfoundation.org, khilman@kernel.org Cc: linux-serial@vger.kernel.org, jslaby@suse.cz, linux-kernel@vger.kernel.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org, Sudhir Sreedharan Subject: [PATCH] tty: serial: 8250_core: Do not call set_sleep for console port Date: Thu, 9 Oct 2014 19:15:26 +0530 Message-Id: <1412862326-6147-1-git-send-email-ssreedharan@mvista.com> X-Mailer: git-send-email 1.7.0.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ST16650V2 based serial uarts, while initalizing the PM state, LCR registers are being initialized to 0 in serial8250_set_sleep(). If console port is already initialized and being used, this will throws garbage in the console. Signed-off-by: Sudhir Sreedharan --- drivers/tty/serial/8250/8250_core.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index ca5cfdc..994aa25 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -2618,6 +2618,9 @@ void serial8250_do_pm(struct uart_port *port, unsigned int state, { struct uart_8250_port *p = up_to_u8250p(port); + if (port->cons && (port->cons->flags & CON_ENABLED) && (state == 0)) + return; + serial8250_set_sleep(p, state != 0); } EXPORT_SYMBOL(serial8250_do_pm); -- 1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/