Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757404AbaJIPI7 (ORCPT ); Thu, 9 Oct 2014 11:08:59 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:64977 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757323AbaJIPIs (ORCPT ); Thu, 9 Oct 2014 11:08:48 -0400 Date: Thu, 9 Oct 2014 16:07:56 +0100 From: Mark Rutland To: Frans Klaver Cc: Sebastian Reichel , =?utf-8?B?UmVuw6k=?= Moll , Tjerk Hofmeijer , Dmitry Eremin-Solenikov , David Woodhouse , "grant.likely@linaro.org" , Rob Herring , Guenter Roeck , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v4 2/2] power: reset: document LTC2952 poweroff support Message-ID: <20141009150756.GC18384@leverpostej> References: <1412866242-6474-1-git-send-email-frans.klaver@xsens.com> <1412866242-6474-3-git-send-email-frans.klaver@xsens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1412866242-6474-3-git-send-email-frans.klaver@xsens.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Oct 09, 2014 at 03:50:42PM +0100, Frans Klaver wrote: > From: René Moll > > Signed-off-by: René Moll > Signed-off-by: Tjerk Hofmeijer > Signed-off-by: Frans Klaver > --- > .../bindings/power/reset/ltc2952-poweroff.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt b/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt > new file mode 100644 > index 0000000..c3f3d9e > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt > @@ -0,0 +1,31 @@ > +Binding for the LTC2952 PowerPath controller > + > +This chip is used to externally trigger a system shut down. Once the trigger > +has been sent, the chips watchdog has to be reset to gracefully shut down. s/chips/chip's/ > If +the Linux systems decides to shut down, it powers off the platform > via the +poweroff signal. This sentence can go; the binding should describe the hardware rather than the Linux behaviour. Thanks, Mark. > + > +Required properties: > + > +- compatible: Must be: "lltc,ltc2952" > +- watchdog-gpios: phandle + gpio-specifier for the GPIO connected to the > + chip's watchdog line > +- poweroff-gpios: phandle + gpio-specifier for the GPIO connected to the > + chip's kill line > + > +Optional properties: > + > +- trigger-gpios: phandle + gpio-specifier for the GPIO connected to the > + chip's trigger line. If this property is not set, the > + trigger function is ignored and the chip is kept alive > + until an explicit kill signal is received > + > +Example: > + > +ltc2952 { > + compatible = "lltc,ltc2952"; > + > + trigger-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; > + watchdog-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; > + poweroff-gpios = <&gpio0 2 GPIO_ACTIVE_LOW>; > +}; > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/