Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbaJISf6 (ORCPT ); Thu, 9 Oct 2014 14:35:58 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:63289 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbaJISfu (ORCPT ); Thu, 9 Oct 2014 14:35:50 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20141009173246.GB466@leverpostej> References: <1412866242-6474-1-git-send-email-frans.klaver@xsens.com> <1412866242-6474-3-git-send-email-frans.klaver@xsens.com> <20141009150756.GC18384@leverpostej> <20141009160935.GF31987@roeck-us.net> <20141009173246.GB466@leverpostej> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH v4 2/2] power: reset: document LTC2952 poweroff support From: Frans Klaver Date: Thu, 09 Oct 2014 20:35:38 +0200 To: Mark Rutland , Guenter Roeck CC: Frans Klaver , Sebastian Reichel , =?ISO-8859-1?Q?Ren=E9_Moll?= , Tjerk Hofmeijer , Dmitry Eremin-Solenikov , David Woodhouse , "grant.likely@linaro.org" , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" Message-ID: <4F86EBD1-D80C-4E9C-BD24-79B895399E14@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9 October 2014 19:32:46 CEST, Mark Rutland wrote: >On Thu, Oct 09, 2014 at 05:09:36PM +0100, Guenter Roeck wrote: >> On Thu, Oct 09, 2014 at 04:07:56PM +0100, Mark Rutland wrote: >> > Hi, >> > >> > On Thu, Oct 09, 2014 at 03:50:42PM +0100, Frans Klaver wrote: >> > > From: René Moll >> > > >> > > Signed-off-by: René Moll >> > > Signed-off-by: Tjerk Hofmeijer >> > > Signed-off-by: Frans Klaver >> > > --- >> > > .../bindings/power/reset/ltc2952-poweroff.txt | 31 >++++++++++++++++++++++ >> > > 1 file changed, 31 insertions(+) >> > > create mode 100644 >Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt >> > > >> > > diff --git >a/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt >b/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt >> > > new file mode 100644 >> > > index 0000000..c3f3d9e >> > > --- /dev/null >> > > +++ >b/Documentation/devicetree/bindings/power/reset/ltc2952-poweroff.txt >> > > @@ -0,0 +1,31 @@ >> > > +Binding for the LTC2952 PowerPath controller >> > > + >> > > +This chip is used to externally trigger a system shut down. Once >the trigger >> > > +has been sent, the chips watchdog has to be reset to gracefully >shut down. >> > >> > s/chips/chip's/ >> > >> > > If +the Linux systems decides to shut down, it powers off the >platform >> > > via the +poweroff signal. >> > >> > This sentence can go; the binding should describe the hardware >rather >> > than the Linux behaviour. >> > >> Maybe find an operating system independent wording and describe what >the >> implementation should do. Or is that out of scope as well ? > >Something like "The platform can be powered off via the poweroff >signal" >would be OK. So long as it's not a description of Linux internals >that's >fine. > >Ideally the binding wouldn't state how the OS should use the device >either. So if bindings can be worded w.r.t. possible uses of a device >rather than specific users, that would be preferable unless the entire >point of the binding is to specify a very specific use. Alright, that makes sense. Thanks, Frans G -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/