Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S264940AbSLGXoF>; Sat, 7 Dec 2002 18:44:05 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S264956AbSLGXoF>; Sat, 7 Dec 2002 18:44:05 -0500
Received: from packet.digeo.com ([12.110.80.53]:9696 "EHLO packet.digeo.com")
	by vger.kernel.org with ESMTP id <S264940AbSLGXoE>;
	Sat, 7 Dec 2002 18:44:04 -0500
Message-ID: <3DF28988.93F268EA@digeo.com>
Date: Sat, 07 Dec 2002 15:51:36 -0800
From: Andrew Morton <akpm@digeo.com>
X-Mailer: Mozilla 4.79 [en] (X11; U; Linux 2.5.46 i686)
X-Accept-Language: en
MIME-Version: 1.0
To: "David S. Miller" <davem@redhat.com>, jgarzik@pobox.com,
       linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [RFC][PATCH] net drivers and cache alignment
References: <3DF2844C.F9216283@digeo.com> <20021207.153045.26640406.davem@redhat.com> <3DF28748.186AB31F@digeo.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 07 Dec 2002 23:51:36.0841 (UTC) FILETIME=[94594790:01C29E4B]
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1140
Lines: 31

Andrew Morton wrote:
> 
> "David S. Miller" wrote:
> >
> >    From: Andrew Morton <akpm@digeo.com>
> >    Date: Sat, 07 Dec 2002 15:29:16 -0800
> >
> >    Jeff Garzik wrote:
> >    > Attached is cut #2.  Thanks for all the near-instant feedback so far :)
> >    >   Andrew, does the attached still need padding on SMP?
> >
> >    It needs padding _only_ on SMP.  ____cacheline_aligned_in_smp.
> >
> > non-smp machines lack L2 caches?  That's new to me :-)
> >
> > More seriously, there are real benefits on non-SMP systems.
> 
> Then I am most confused.  None of these fields will be put under
> busmastering or anything like that, so what advantage is there in
> spreading them out?

Oh I see what you want - to be able to pick up all the operating fields
in a single fetch.

That will increase the overall cache footprint though.  I wonder if
it's really a net win, over just keeping it small.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/