Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751103AbaJKCOV (ORCPT ); Fri, 10 Oct 2014 22:14:21 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:45979 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750706AbaJKCOT (ORCPT ); Fri, 10 Oct 2014 22:14:19 -0400 Date: Sat, 11 Oct 2014 18:11:02 +0800 From: Fengwei Yin To: Dave Hansen Cc: LKML , linux-mm@kvack.org, fengguang.wu@intel.com, "Kirill A. Shutemov" Subject: Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page Message-ID: <20141011101020.GA26953@gmail.com> References: <5436B98E.1070407@intel.com> <20141010132027.GB25038@gmail.com> <5437EEA3.50705@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5437EEA3.50705@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: > On 10/10/2014 06:21 AM, Fengwei Yin wrote: > > @@ -787,6 +788,9 @@ check_pfn: > > return NULL; > > } > > > > + if (is_huge_zero_pfn(pfn)) > > + return NULL; > > + > > That looks a lot better. One thing, why not put the is_huge_zero_pfn() > check next to the is_zero_pfn() check? On the arch which has PTE_SPECIAL feaure, we need to make sure the is_huge_zero_pfn() is called after the pfn is checked if !pte_special(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/