Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbaJKRIe (ORCPT ); Sat, 11 Oct 2014 13:08:34 -0400 Received: from smtprelay0126.hostedemail.com ([216.40.44.126]:43353 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751147AbaJKRId (ORCPT ); Sat, 11 Oct 2014 13:08:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3865:3866:3870:3871:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:7514:7652:8957:9025:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pets42_2d4dcec865336 X-Filterd-Recvd-Size: 1401 Message-ID: <1413047310.16385.31.camel@joe-AO725> Subject: Re: [PATCH] usb: atm: fix codestyle issues in From: Joe Perches To: Lars Melin Cc: Jonas Brunsgaard , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 11 Oct 2014 10:08:30 -0700 In-Reply-To: <5439621C.20405@gmail.com> References: <1413043368-24548-1-git-send-email-jonas.brunsgaard@gmail.com> <5439621C.20405@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2014-10-12 at 00:00 +0700, Lars Melin wrote: > On 2014-10-11 23:02, Jonas Brunsgaard wrote: > > Signed-off-by: Jonas Brunsgaard [] > > diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c [ 15 KB of quoted stuff ] > Read: > https://www.kernel.org/doc/Documentation/CodingStyle Besides needlessly quoting a large quantity of the previous email, this is an unhelpful comment. Point out what's wrong with the patch. AFAICT, nothing in particular. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/