Message-ID: <1413052541.22149.10.camel@joe-AO725>
Subject: Re: [PATCH] char: misc: use pr_err instead of printk
From: Joe Perches <joe@perches.com>
To: Rahul Bedarkar <rahulbedarkar89@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Date: Sat, 11 Oct 2014 11:35:41 -0700
In-Reply-To: <1413052311-2646-1-git-send-email-rahulbedarkar89@gmail.com>
References: <1413052311-2646-1-git-send-email-rahulbedarkar89@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote:
[]
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
[]
> @@ -280,12 +280,12 @@ static int __init misc_init(void)
>  
>  	err = -EIO;
>  	if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
> -		goto fail_printk;
> +		goto fail_pr_err;
>  	misc_class->devnode = misc_devnode;
>  	return 0;
>  
> -fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +fail_pr_err:
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
>  	class_destroy(misc_class);
>  fail_remove:
>  	remove_proc_entry("misc", NULL);

The printk is not relevant.
Maybe the label should be "fail_destroy:"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/