Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbaJKUUF (ORCPT ); Sat, 11 Oct 2014 16:20:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57809 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbaJKUUE (ORCPT ); Sat, 11 Oct 2014 16:20:04 -0400 Date: Sat, 11 Oct 2014 13:19:01 -0700 From: Greg KH To: Joe Perches Cc: Philip Munksgaard , johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: serial: Fix indentation style issue Message-ID: <20141011201901.GD29439@kroah.com> References: <1413035383-3981-1-git-send-email-pmunksgaard@gmail.com> <20141011142049.GA11456@kroah.com> <1413041793.16385.22.camel@joe-AO725> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413041793.16385.22.camel@joe-AO725> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > Fix a style issue > [] > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > [] > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = { > > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) }, > > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14), > > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist > > > - }, > > > + }, > > > > Why not fix the same 'space' issue on the line before this at the same > > time? > > I think there is no space issue on the previous line. > What do you see Greg? I see 'space space tab', just like this line that is being changed. /me hands Joe a real editor. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/