Message-ID: <1413075731.22149.12.camel@joe-AO725>
Subject: Re: [PATCH] usb: serial: Fix indentation style issue
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Philip Munksgaard <pmunksgaard@gmail.com>, johan@kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sat, 11 Oct 2014 18:02:11 -0700
In-Reply-To: <20141011201901.GD29439@kroah.com>
References: <1413035383-3981-1-git-send-email-pmunksgaard@gmail.com>
	 <20141011142049.GA11456@kroah.com> <1413041793.16385.22.camel@joe-AO725>
	 <20141011201901.GD29439@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sat, 2014-10-11 at 13:19 -0700, Greg KH wrote:
> On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote:
> > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote:
> > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote:
> > > > Fix a style issue
> > []
> > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > []
> > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
> > > >  	{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
> > > >  	{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
> > > >    	  .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
> > > > -  	},
> > > > +	},
> > > 
> > > Why not fix the same 'space' issue on the line before this at the same
> > > time?
> > 
> > I think there is no space issue on the previous line.
> > What do you see Greg?
> 
> I see 'space space tab', just like this line that is being changed.

Right, silly evolution previewer can't differentiate space/tab

> /me hands Joe a real editor.

Well, where is it? ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/