Message-ID: <543AA8BF.7090809@myspectrum.nl>
Date: Sun, 12 Oct 2014 18:13:51 +0200
From: Jeroen Hofstee <jeroen@myspectrum.nl>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2
MIME-Version: 1.0
To: Hans de Goede <hdegoede@redhat.com>,
        "Yann E. MORIN" <yann.morin.1998@free.fr>, u-boot@lists.denx.de
CC: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c
References: <1413109527-10718-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1413109527-10718-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hello Hans,

On 12-10-14 12:25, Hans de Goede wrote:
> Hi,
>
> This one seems to have fallen through the cracks.
>
> Regards,
>
> Hans
>
(for U-boot)

nope, you replace an innocent warning (_might_ be) with
bad code, without any comment it is just because gcc failed
to recognize it is fine. Nor did you respond to the suggestion
if it helps gcc to recognize that if the two booleans are merged
into a single one. [or even split it in an if () if ()]. With this patch
you prevent any serious warning in case the variable is actually
used but not initialized, which is even worse if you ask me.

Regards,
Jeroen


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/