Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbaJMJxO (ORCPT ); Mon, 13 Oct 2014 05:53:14 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:52713 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752937AbaJMJxN (ORCPT ); Mon, 13 Oct 2014 05:53:13 -0400 Date: Mon, 13 Oct 2014 10:53:10 +0100 From: Matt Fleming To: Sam Protsenko Cc: Matt Fleming , Leif Lindholm , hock.leong.kweh@intel.com, "linux-efi@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] efi: Capsule update support Message-ID: <20141013095310.GZ14343@console-pimps.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Oct, at 06:55:49PM, Sam Protsenko wrote: > Hi Matt, > > 1. Why x86 code isn't separated to another patch? When I originally wrote this patch in 2013 arm64 support didn't exist, and ia64 isn't going to be using capsule support. I can separate that out into a separate patch though, no problem. > 2. drivers/firmware/efi/reboot.c: efi_reboot(): > One shouldn't use "printk()" with no KERN_* stuff passed into it. > I'd recommend to use "pr_info()" macro or something like that. Oops, I missed that, good catch. Next time, could you please quote the part of the patch you're commenting on inline? That would have saved me searching through the original email. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/