Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753750AbaJMNeL (ORCPT ); Mon, 13 Oct 2014 09:34:11 -0400 Received: from static.92.5.9.176.clients.your-server.de ([176.9.5.92]:40939 "EHLO mail.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbaJMNeK (ORCPT ); Mon, 13 Oct 2014 09:34:10 -0400 Date: Mon, 13 Oct 2014 15:34:08 +0200 From: "Serge E. Hallyn" To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, eparis@redhat.com, sgrubb@redhat.com, aviro@redhat.com, pmoore@redhat.com, arozansk@redhat.com, ebiederm@xmission.com, serge@hallyn.com Subject: Re: [PATCH V5 11/13] audit: emit AUDIT_NS_INFO record with AUDIT_VIRT_CONTROL record Message-ID: <20141013133408.GJ24703@mail.hallyn.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Richard Guy Briggs (rgb@redhat.com): > Signed-off-by: Richard Guy Briggs > --- > include/uapi/linux/audit.h | 2 ++ > kernel/audit.c | 2 ++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h > index 7ec7209..beb23f7 100644 > --- a/include/uapi/linux/audit.h > +++ b/include/uapi/linux/audit.h > @@ -163,6 +163,8 @@ > > #define AUDIT_KERNEL 2000 /* Asynchronous audit record. NOT A REQUEST. */ > > +#define AUDIT_VIRT_CONTROL 2500 /* Start, Pause, Stop VM */ > + > /* Rule flags */ > #define AUDIT_FILTER_USER 0x00 /* Apply rule to user-generated messages */ > #define AUDIT_FILTER_TASK 0x01 /* Apply rule at task creation (not syscall) */ > diff --git a/kernel/audit.c b/kernel/audit.c > index 84590d1..5404c24 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -941,6 +941,8 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) > } > audit_set_portid(ab, NETLINK_CB(skb).portid); > audit_log_end(ab); > + if (msg_type == AUDIT_VIRT_CONTROL) > + audit_log_ns_info(NULL); AFAICT your patchset leaves audit_log_ns_info() immediately returning if arg1 is NULL. Is handling that coming later? Why not leave this until that patch comes? > mutex_lock(&audit_cmd_mutex); > } > break; > -- > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/