From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Mark Brown <broonie@kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dp@opensource.wolfsonmicro.com" <dp@opensource.wolfsonmicro.com>
Subject: RE: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().
Thread-Topic: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().
Thread-Index: AQHP45/nWVV96Oe+skSyutrZg0NFZJwt3uAAgAD8DrA=
Date: Tue, 14 Oct 2014 01:52:48 +0000
Message-ID: <e4424702b10c49a1a04b713b3e00a55d@BY2PR0301MB0613.namprd03.prod.outlook.com>
References: <1412845377-17134-1-git-send-email-Li.Xiubo@freescale.com>
 <1412845377-17134-3-git-send-email-Li.Xiubo@freescale.com>
 <20141013104720.GM27755@sirena.org.uk>
In-Reply-To: <20141013104720.GM27755@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

Hi Mark,

> Subject: Re: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().
> 
> On Thu, Oct 09, 2014 at 05:02:53PM +0800, Xiubo Li wrote:
> > Remove the redundant code for regmap cache.
> 
> Applied, thanks.  With changes like this it is much better if the
> changelog explains why the code is redundant - say in words that the
> value used is never referenced and looking up the value has no side
> effects.

Thanks verrrry much for your comment and your always patient guidance.

BRs
Xiubo 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/