Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755482AbaJNTYo (ORCPT ); Tue, 14 Oct 2014 15:24:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754340AbaJNTYn (ORCPT ); Tue, 14 Oct 2014 15:24:43 -0400 Date: Tue, 14 Oct 2014 16:24:38 -0300 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: Namhyung Kim , LKML , Jiri Olsa , Peter Zijlstra , Ingo Molnar , David Ahern , Arnaldo Carvalho de Melo Subject: Re: [PATCH v2] perf tools: fix off-by-one error in maps Message-ID: <20141014192438.GA6234@redhat.com> References: <20141006083532.GA4850@quad> <8761fwh1nc.fsf@sejong.aot.lge.com> <20141007140050.GB2256@redhat.com> <20141007151035.GC2256@redhat.com> <20141014185829.GA3839@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 14, 2014 at 09:03:02PM +0200, Stephane Eranian escreveu: > On Tue, Oct 14, 2014 at 8:58 PM, Arnaldo Carvalho de Melo > > struct vm_area_struct { > > /* The first cache line has the info for VMA tree walking. */ > > unsigned long vm_start; /* Our start address within vm_mm. */ > > unsigned long vm_end; /* The first byte after our end address > > within vm_mm. */ > > So these guys have been doing this far longer than me, I guess I'll bow > > to this convention. > > But by renaming map->end to map->end_ and looking at all the usage of > > it, there are some inconsistencies... > > Like symbol->{start,end} is of the [start,end] case, and to be > > consistent with above needs to also move to [start,end[, will cook a > > patch and send for review. > Yes, there were some inconsistencies (or confusions) that I noticed when > I started fixing the maps. I can believe that this off-by-one error exist with > other data types. That could cause wrong symbol correlations in borderline > cases (which are really rare). Yeah, I'll try and fix one by one in separate patches when applicable. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/