Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755647AbaJNUSN (ORCPT ); Tue, 14 Oct 2014 16:18:13 -0400 Received: from mailsec102.isp.belgacom.be ([195.238.20.98]:44154 "EHLO mailsec102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755470AbaJNUSL convert rfc822-to-8bit (ORCPT ); Tue, 14 Oct 2014 16:18:11 -0400 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=xmGiAQlKtCF5+ra7FDB8hpYjXxwBLBdzsqYiSFHyMzI= c=1 sm=2 a=IkcTkHD0fZMA:10 a=Yvs7EeInAAAA:8 a=cOu4thG3uavfUlSrHS4A:9 a=QEXdDO2ut3YA:10 a=myC0mAPUGvMA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al8fANeDPVTD7hTS/2dsb2JhbABbgw6BK4MGtXIGmwkCgRYWAX0EMwEBg0kBAQEDASNWBQsFBg4KAgIYDgICVwYTEYglDLF8hn+OKgEBAQcCAR+BLIR0iiUHgneBVAWYfZEqiTWDeTsvgkoBAQE Date: Tue, 14 Oct 2014 22:18:09 +0200 (CEST) From: Fabian Frederick Reply-To: Fabian Frederick To: Zach Brown Cc: Josef Bacik , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, Chris Mason Message-ID: <468850260.110326.1413317889395.open-xchange@webmail.nmp.skynet.be> In-Reply-To: <20141014191542.GB6838@lenny.home.zabbo.net> References: <1413308774-9985-1-git-send-email-fabf@skynet.be> <20141014191542.GB6838@lenny.home.zabbo.net> Subject: Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 14 October 2014 at 21:15 Zach Brown wrote: > > > On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: > > use function defined in include/linux/highmem.h > > Note that this reverts 2 last function call order > > And adds a BUG_ON(PAGE_CACHE_SIZE > PAGE_SIZE).  We can take bets on > whether that will ever trigger. There are 36 zero_user_segment with PAGE_CACHE_SIZE callsites. Maybe we could add some specific function to avoid BUG_ON tests ? Fabian > > - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/