Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755637AbaJNUYJ (ORCPT ); Tue, 14 Oct 2014 16:24:09 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:53273 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755598AbaJNUYF (ORCPT ); Tue, 14 Oct 2014 16:24:05 -0400 MIME-Version: 1.0 In-Reply-To: <1413231122-1770-5-git-send-email-kever.yang@rock-chips.com> References: <1413231122-1770-1-git-send-email-kever.yang@rock-chips.com> <1413231122-1770-5-git-send-email-kever.yang@rock-chips.com> Date: Tue, 14 Oct 2014 13:24:03 -0700 X-Google-Sender-Auth: FxOoOzBYHM7bsXVSQEYTsjurKFI Message-ID: Subject: Re: [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288 From: Doug Anderson To: Kever Yang Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Sonny Rao , Addy Ke , Eddie Cai , Jianqun Xu , han jiang , Tao Huang , linux-rockchip@lists.infradead.org, Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kever, On Mon, Oct 13, 2014 at 1:12 PM, Kever Yang wrote: > + /* > + * We need to soft reset the cpu when we turn off the cpu power domain, > + * or else the active processors might be stalled when the individual > + * processor is powered down. > + */ > + if (read_cpuid_part_number() != ARM_CPU_PART_CORTEX_A9) { I haven't done a full review of this patch, but it seems unlikely that your uses of read_cpuid_part_number() and read_cpuid_part() in this patch are correct. You use both functions and in both cases compare the results to ARM_CPU_PART_CORTEX_A9. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/