Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbaJNU6X (ORCPT ); Tue, 14 Oct 2014 16:58:23 -0400 Received: from smtprelay.synopsys.com ([198.182.44.111]:36809 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbaJNU6W convert rfc822-to-8bit (ORCPT ); Tue, 14 Oct 2014 16:58:22 -0400 From: Paul Zimmerman To: Sudip Mukherjee CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "balbi@ti.com" Subject: RE: [PATCH] usb: dwc2: gadget: sparse warning of context imbalance Thread-Topic: [PATCH] usb: dwc2: gadget: sparse warning of context imbalance Thread-Index: AQHP5It6FLj+ET7LSEu1+TkR/GU3RJwwFWWQ Date: Tue, 14 Oct 2014 20:55:55 +0000 Message-ID: References: <1412946579-6805-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1412946579-6805-1-git-send-email-sudipm.mukherjee@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.64.241] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com] > Sent: Friday, October 10, 2014 6:10 AM > > sparse was giving the following warning: > warning: context imbalance in 's3c_hsotg_ep_enable' > - different lock contexts for basic block > > we were returning ENOMEM while still holding the spinlock. > The sparse warning was fixed by releasing the spinlock before return. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/dwc2/gadget.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index 7b5856f..046e90d 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2561,8 +2561,10 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > hs_ep->fifo_size = val; > break; > } > - if (i == 8) > + if (i == 8) { > + spin_unlock_irqrestore(&hsotg->lock, flags); > return -ENOMEM; > + } > } > > /* for non control endpoints, set PID to D0 */ For a long function like this, I'd rather keep a single return point at the end. Something like this: } - if (i == 8) - return -ENOMEM; + if (i == 8) { + ret = -ENOMEM; + goto out; + } } ... +out: spin_unlock_irqrestore(&hsotg->lock, flags); return ret; } Care to respin the patch like that? -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/