Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbaJNVYE (ORCPT ); Tue, 14 Oct 2014 17:24:04 -0400 Received: from gloria.sntech.de ([95.129.55.99]:55576 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932569AbaJNVYA (ORCPT ); Tue, 14 Oct 2014 17:24:00 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Doug Anderson Cc: Kever Yang , Sonny Rao , Addy Ke , Eddie Cai , Jianqun Xu , han jiang , Tao Huang , linux-rockchip@lists.infradead.org, Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288 Date: Tue, 14 Oct 2014 23:23:40 +0200 Message-ID: <1453932.GC4UXrUPRz@phil> User-Agent: KMail/4.11.5 (Linux/3.13-1-amd64; KDE/4.11.3; x86_64; ; ) In-Reply-To: References: <1413231122-1770-1-git-send-email-kever.yang@rock-chips.com> <1413231122-1770-5-git-send-email-kever.yang@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 14. Oktober 2014, 13:24:03 schrieb Doug Anderson: > Kever, > > On Mon, Oct 13, 2014 at 1:12 PM, Kever Yang wrote: > > + /* > > + * We need to soft reset the cpu when we turn off the cpu power > > domain, + * or else the active processors might be stalled when > > the individual + * processor is powered down. > > + */ > > + if (read_cpuid_part_number() != ARM_CPU_PART_CORTEX_A9) { > > I haven't done a full review of this patch, but it seems unlikely that > your uses of read_cpuid_part_number() and read_cpuid_part() in this > patch are correct. You use both functions and in both cases compare > the results to ARM_CPU_PART_CORTEX_A9. I think read_cpuid_part() would be the correct one, as it does read_cpuid_id() & ARM_CPU_PART_MASK which in turn should mask the correct parts of the cpuid to match against ARM_CPU_PART_CORTEX_A9 [0]. [0] http://lxr.free-electrons.com/source/arch/arm/include/asm/cputype.h#L77 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/