Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbaJOGxG (ORCPT ); Wed, 15 Oct 2014 02:53:06 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:5742 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbaJOGxD (ORCPT ); Wed, 15 Oct 2014 02:53:03 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 14 Oct 2014 23:52:41 -0700 Message-ID: <543E19C5.3040200@nvidia.com> Date: Wed, 15 Oct 2014 14:52:53 +0800 From: Joseph Lo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Jingchang Lu , "gregkh@linuxfoundation.org" CC: "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , "peter@hurleysoftware.com" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on no_console_suspend and port type References: <1413276146-20388-1-git-send-email-jingchang.lu@freescale.com> <543DC753.4070304@nvidia.com> <67564f37252242079bcd4c65827b8352@BL2PR03MB467.namprd03.prod.outlook.com> <543E1730.2040108@nvidia.com> In-Reply-To: <543E1730.2040108@nvidia.com> X-Originating-IP: [10.19.108.115] X-ClientProxiedBy: DRBGMAIL103.nvidia.com (10.18.16.22) To HKMAIL102.nvidia.com (10.18.16.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2014 02:41 PM, Joseph Lo wrote: > On 10/15/2014 02:32 PM, Jingchang Lu wrote: >>> -----Original Message----- >>> From: Joseph Lo [mailto:josephl@nvidia.com] >>> Sent: Wednesday, October 15, 2014 9:01 AM >>> To: Lu Jingchang-B35083; gregkh@linuxfoundation.org >>> Cc: peter@hurleysoftware.com; arnd@arndb.de; linux-kernel@vger.kernel.org; >>> linux-serial@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on >>> no_console_suspend and port type >>> >>> On 10/14/2014 04:42 PM, Jingchang Lu wrote: >>>> This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e, >>>> "serial: of-serial: add PM suspend/resume support", which disables the >>>> uart clock on suspend, but also causes a hardware hang on register >>>> access if no_console_suspend command line option is used. >>>> >>>> Also, not every of_serial device is an 8250 port, so the serial8250 >>>> suspend/resume functions should only be applied to a real 8250 port. >>>> >>>> Signed-off-by: Jingchang Lu >>> >>> If you can make sure this patch can build without include >>> , then this patch >> The build passes on my cloned linux-next tree, include next-20141014, >> but is required on my another kernel-3.12+ based tree, then I didn't >> add this header file when upstream. >> Is the build broken on your source tree, and is the tree latest? >> If the header is needed, I will add it. > I tested it on next-20141013 and k3.14, both of them need the fix. I can > check it again against the latest linux-next tree later. Thanks. > OK, I confirmed it. You should add the header file. It also doesn't build for me with the latest linux-next tree. Maybe you missed to enable CONFIG_PM_SLEEP or CONFIG_SERIAL_8250 when doing the build test in linux-next tree. -Joseph -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/