Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbaJOKMQ (ORCPT ); Wed, 15 Oct 2014 06:12:16 -0400 Received: from 1wt.eu ([62.212.114.60]:32265 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbaJOKMP (ORCPT ); Wed, 15 Oct 2014 06:12:15 -0400 Date: Wed, 15 Oct 2014 12:09:49 +0200 From: Willy Tarreau To: Zhu Yanjun Cc: sandeep.kumar@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yue.Tao@windriver.com, guang.yang@windriver.com, joe@perches.com, festevam@gmail.com, richardcochran@gmail.com, clarocq@gmail.com, yongjun_wei@trendmicro.com.cn, claudiu.manoil@freescale.com, roy.xu@huawei.com, sky.wangfeng@huawei.com, Zhu Yanjun Subject: Re: [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x Message-ID: <20141015100949.GA30089@1wt.eu> References: <1413367234-28652-1-git-send-email-Yanjun.Zhu@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413367234-28652-1-git-send-email-Yanjun.Zhu@windriver.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhu, On Wed, Oct 15, 2014 at 06:00:33PM +0800, Zhu Yanjun wrote: > In commit f43c75d4b6[gianfar: disable TX vlan based on kernel 2.6.x], > gianfar nic disables TX vlan. But gianfar nic enables vlan tag > insertion by default. This will lead to unusable connections on > some configurations. Since vlan tag insertion is disabled by default > and it is not enabled any longer, it is not necessary to disable it again. > > Zhu Yanjun (1): > gianfar: disable vlan tag insertion by default > > drivers/net/gianfar.c | 6 ------ > 1 file changed, 6 deletions(-) > > -- > 1.9.1 There's no patch in this e-mail. Since you sent another e-mail with almost the same subject, I'm confused, it's unclear to me whether I only need to apply the patch in the other one with this commit message or if it's just that you accidently dropped the patch when sending this e-mail. Could you please enlighten me ? Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/