Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbaJONJK (ORCPT ); Wed, 15 Oct 2014 09:09:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbaJONJH (ORCPT ); Wed, 15 Oct 2014 09:09:07 -0400 Date: Wed, 15 Oct 2014 09:06:28 -0400 From: Vivek Goyal To: WANG Chao Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "maintainer:X86 ARCHITECTURE..." , Andrew Morton , Baoquan He , Stephen Rothwell , "open list:X86 ARCHITECTURE..." Subject: Re: [PATCH] arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message Message-ID: <20141015130628.GA3450@redhat.com> References: <1413262019-3759-1-git-send-email-chaowang@redhat.com> <20141014215253.GM5127@redhat.com> <20141015021431.GE2013@dhcp-17-37.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141015021431.GE2013@dhcp-17-37.nay.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote: > On 10/14/14 at 05:52pm, Vivek Goyal wrote: > > On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote: > > > Supress this unnecessary message during kernel re-build > > > (CONFIG_KEXEC_FILE=y): > > > > > > make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date. > > > > > > Signed-off-by: WANG Chao > > > --- > > > arch/x86/purgatory/Makefile | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile > > > index f52e033..2c835e3 100644 > > > --- a/arch/x86/purgatory/Makefile > > > +++ b/arch/x86/purgatory/Makefile > > > @@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C $@ > > > > > > $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE > > > $(call if_changed,bin2c) > > > + @: > > > > Where can I find the description of "@:" and how does it work? > > @ is used to suppress echo'ing. See: > https://www.gnu.org/software/make/manual/html_node/Echoing.html > > This is a trick to avoid "... is up to date" message". Check out commit > a9358bc ("x86/build: Supress realmode.bin is up to date message"). Thanks for the explanations. Looks good to me. Acked-by: Vivek Goyal Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/