Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751705AbaJOWGi (ORCPT ); Wed, 15 Oct 2014 18:06:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:36171 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaJOWGh (ORCPT ); Wed, 15 Oct 2014 18:06:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="400917797" Date: Wed, 15 Oct 2014 15:06:54 -0700 From: David Cohen To: Ian Abbott Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, trivial@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: ii_pci20kc: add CONFIG_HAS_IOMEM dependence Message-ID: <20141015220654.GE4529@psi-dev26.jf.intel.com> References: <1413408339-12816-1-git-send-email-david.a.cohen@linux.intel.com> <543EEDAC.7050800@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <543EEDAC.7050800@mev.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 10:57:00PM +0100, Ian Abbott wrote: > On 15/10/14 22:25, David Cohen wrote: > >ii_pci20kc uses io memory which makes it not compilable on architectures > >without HAS_IOMEM such as UML: > > > > CC drivers/net/wireless/ti/wl1251/main.o > >drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’: > >drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit > >declaration of function ‘ioremap’ > >[-Werror=implicit-function-declaration] > > dev->mmio = ioremap(membase, II20K_SIZE); > > ^ > >drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment > >makes pointer from integer without a cast > > dev->mmio = ioremap(membase, II20K_SIZE); > > ^ > >drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: > >drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit > >declaration of function ‘iounmap’ > >[-Werror=implicit-function-declaration] > > iounmap(dev->mmio); > > ^ > > > >Signed-off-by: David Cohen > >--- > > drivers/staging/comedi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig > >index a8bc2b567789..56be2112c731 100644 > >--- a/drivers/staging/comedi/Kconfig > >+++ b/drivers/staging/comedi/Kconfig > >@@ -425,6 +425,7 @@ config COMEDI_AIO_IIRO_16 > > called aio_iiro_16. > > > > config COMEDI_II_PCI20KC > >+ depends on HAS_IOMEM > > tristate "Intelligent Instruments PCI-20001C carrier support" > > ---help--- > > Enable support for Intelligent Instruments PCI-20001C carrier > > > > The same fix was already submitted by Chen Gang: > > https://lkml.org/lkml/2014/10/2/318 Thanks. I sent this patch based on today's linux-next's "make ARCH=um allyesconfig". But nevermind if it was already sent. Br, David > > Reviewed-by: Ian Abbott > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: )=- > -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/