Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbaJOXf1 (ORCPT ); Wed, 15 Oct 2014 19:35:27 -0400 Received: from mail-qg0-f52.google.com ([209.85.192.52]:60785 "EHLO mail-qg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbaJOXfZ (ORCPT ); Wed, 15 Oct 2014 19:35:25 -0400 MIME-Version: 1.0 In-Reply-To: <20141015170637.4063.22185.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20141015165957.4063.66741.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20141015170637.4063.22185.stgit@bhelgaas-glaptop2.roam.corp.google.com> From: Bjorn Helgaas Date: Wed, 15 Oct 2014 17:35:05 -0600 Message-ID: Subject: Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration To: Jason Wessel , Ralf Baechle , Ingo Molnar , John Stultz , Eric Paris , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton Cc: "linux-kernel@vger.kernel.org" , Harvey Harrison , Vineet Gupta , "linux-sh@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Harvey, Vineet, linux-sh; arc, sh, and x86 have kgdb_arch_pc() definitions and could see issues from this] On Wed, Oct 15, 2014 at 11:06 AM, Bjorn Helgaas wrote: > kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition > explicitly marked "weak". Several architectures provide their own > definitions intended to override the default, but the "weak" attribute on > the declaration applied to the arch definitions as well, so the linker > chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak > annotation from pcibios_get_phb_of_node decl")). > > Remove the "weak" attribute from the declaration so we always prefer a > non-weak definition over the weak one, independent of link order. > > Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add declaration to header") > Signed-off-by: Bjorn Helgaas > CC: Harvey Harrison > --- > include/linux/kgdb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h > index 6b06d378f3df..e465bb15912d 100644 > --- a/include/linux/kgdb.h > +++ b/include/linux/kgdb.h > @@ -283,7 +283,7 @@ struct kgdb_io { > > extern struct kgdb_arch arch_kgdb_ops; > > -extern unsigned long __weak kgdb_arch_pc(int exception, struct pt_regs *regs); > +extern unsigned long kgdb_arch_pc(int exception, struct pt_regs *regs); > > #ifdef CONFIG_SERIAL_KGDB_NMI > extern int kgdb_register_nmi_console(void); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/