Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbaJPHVX (ORCPT ); Thu, 16 Oct 2014 03:21:23 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:40982 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbaJPHVV (ORCPT ); Thu, 16 Oct 2014 03:21:21 -0400 From: Kevin Hilman To: Sudhir Sreedharan Cc: peter@hurleysoftware.com, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, jslaby@suse.cz, linux-kernel@vger.kernel.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org Subject: Re: [PATCH] tty: serial: 8250_core: restore the LCR register in set_sleep References: <54369F77.5000906@hurleysoftware.com> <1413355395-5871-1-git-send-email-ssreedharan@mvista.com> Date: Thu, 16 Oct 2014 00:21:17 -0700 In-Reply-To: <1413355395-5871-1-git-send-email-ssreedharan@mvista.com> (Sudhir Sreedharan's message of "Wed, 15 Oct 2014 12:13:15 +0530") Message-ID: <7hwq80h442.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sudhir Sreedharan writes: > In ST16650V2 based serial uarts, while initalizing the PM state, > LCR registers are being initialized to 0 in serial8250_set_sleep(). > If console port is already initialized and being used, this will > throws garbage in the console. > > Signed-off-by: Sudhir Sreedharan Since this caused regressions in -next last time, could you describe how this was tested, and on what platforms? Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/