Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbaJPI7I (ORCPT ); Thu, 16 Oct 2014 04:59:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:22454 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbaJPI7E (ORCPT ); Thu, 16 Oct 2014 04:59:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,731,1406617200"; d="scan'208";a="619743995" Message-ID: <543F88BE.4090307@intel.com> Date: Thu, 16 Oct 2014 16:58:38 +0800 From: Aaron Lu MIME-Version: 1.0 To: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , rui.zhang@intel.com, edubezval@gmail.com, linux-pm@vger.kernel.org Subject: [PATCH] Thermal: int3406_thermal: solve the dependency build error References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2014 10:43 PM, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `int3406_thermal_probe': > int3406_thermal.c:(.text+0x1d10b8): undefined reference to > `acpi_video_get_levels' > make: *** [vmlinux] Error 1 Thanks for the report Jim, below patch should fix this problem: From: Aaron Lu Date: Thu, 16 Oct 2014 16:35:02 +0800 Subject: [PATCH] Thermal: int3406_thermal: solve the dependency build error Jim found that the current kernel may trigger a build error with some config: drivers/built-in.o: In function `int3406_thermal_probe': int3406_thermal.c:(.text+0x1d10b8): undefined reference to `acpi_video_get_levels'. The problem happens when CONFIG_THERMAL=y and CONFIG_ACPI_VIDEO=m. Since the ACPI video driver can still work well without CONFIG_THERMAL(regarding its main functionality: backlight control), solve the problem by removing the select THERMAL line for ACPI_VIDEO and adding the select ACPI_VIDEO for INT340X_THERMAL. The result is that for kernels that do not have CONFIG_THERMAL selected now, the ACPI video driver will not create the cooling device as it did before(but works well otherwise). Reported-by: Jim Davis Signed-off-by: Aaron Lu --- drivers/acpi/Kconfig | 1 - drivers/thermal/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index b23fe37f67c0..8a09f98dbb0c 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -131,7 +131,6 @@ config ACPI_VIDEO tristate "Video" depends on X86 && BACKLIGHT_CLASS_DEVICE depends on INPUT - select THERMAL help This driver implements the ACPI Extensions For Display Adapters for integrated graphics devices on motherboard, as specified in diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 9b012ff65220..4e1053a8d774 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -235,6 +235,7 @@ config INT340X_THERMAL select THERMAL_GOV_USER_SPACE select ACPI_THERMAL_REL select ACPI_FAN + select ACPI_VIDEO help Newer laptops and tablets that use ACPI may have thermal sensors and other devices with thermal control capabilities outside the core -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/