Message-ID: <1413452333.6702.1.camel@perches.com>
Subject: Re: [PATCH] kernel:module Fix coding style errors and warnings.
From: Joe Perches <joe@perches.com>
To: Ionut Alexa <ionut.m.alexa@gmail.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Date: Thu, 16 Oct 2014 02:38:53 -0700
In-Reply-To: <1413452213-27450-1-git-send-email-ionut.m.alexa@gmail.com>
References: <1413452213-27450-1-git-send-email-ionut.m.alexa@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
> Fixed codin style errors and warnings. Changes printk with
> print_debug/warn. Changed seq_printf to seq_puts.

If you are going to do style cleanups, please make
sure you check your patches with scripts/checkpatch.pl
before sending them.

WARNING: missing space after struct definition
#104: FILE: kernel/module.c:743:
+struct stopref{

WARNING: line over 80 characters
#190: FILE: kernel/module.c:1550:
+			error = sysfs_create_file(&mod->mkobj.kobj, &temp_attr->attr);

total: 0 errors, 2 warnings, 187 lines checked


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/