Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbaJPKYO (ORCPT ); Thu, 16 Oct 2014 06:24:14 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38775 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbaJPKYL (ORCPT ); Thu, 16 Oct 2014 06:24:11 -0400 X-Originating-IP: 62.156.150.204 Date: Thu, 16 Oct 2014 12:24:05 +0200 From: Josh Triplett To: Greg Kroah-Hartman Cc: Aristeu Rozanski , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Message-ID: <20141016102404.GB1077@thin> References: <20141015152522.GL5930@redhat.com> <20141015231446.GD685@kroah.com> <20141016035157.GA25133@thin> <20141016101843.GB25971@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141016101843.GB25971@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote: > > On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote: > > > > It's desirable for allnconfig and tinyconfig targets to result in the > > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to > > > > switch off DEV_COREDUMP regardless if any drivers select > > > > WANT_DEV_COREDUMP. > > > > > > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device > > > > coredump. > > > > > > > > Cc: Greg Kroah-Hartman > > > > Cc: Josh Triplett > > > > Reviewed-by: Josh Triplett > > > > Signed-off-by: Aristeu Rozanski > > > > > > Any reason you didn't cc: the author of this feature / Kconfig option > > > about this change you are proposing? > > > > Likely my fault; I'd suggested using get_maintainer.pl, which does not > > show that for this patch: > > > > ~/src/linux$ scripts/get_maintainer.pl < /tmp/patch > > Greg Kroah-Hartman (supporter:DRIVER CORE, KOBJ...) > > linux-kernel@vger.kernel.org (open list) > > Yes, as that's just the Kconfig file, but at least let the person who > wrote that entry a chance to review it, that's just "being nice" :) I agree; I'm just saying blame me rather than Aristeu. :) - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/