Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbaJPK1A (ORCPT ); Thu, 16 Oct 2014 06:27:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58408 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbaJPK05 (ORCPT ); Thu, 16 Oct 2014 06:26:57 -0400 Date: Thu, 16 Oct 2014 12:26:36 +0200 From: Mark Brown To: addy ke Cc: heiko@sntech.de, dianders@chromium.org, grant.likely@linaro.org, robh+dt@kernel.org, amstan@google.com, sonnyrao@google.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, olof@lixom.net, hj@rock-chips.com, kever.yang@rock-chips.com, xjq@rock-chips.com, huangtao@rock-chips.com, zyw@rock-chips.com, yzq@rock-chips.com, zhenfu.fang@rock-chips.com, cf@rock-chips.com, zhangqing@rock-chips.com, hl@rock-chips.com, wei.luo@rock-chips.com Message-ID: <20141016102636.GE2200@sirena.org.uk> References: <1413372311-4203-1-git-send-email-addy.ke@rock-chips.com> <1413372349-4254-1-git-send-email-addy.ke@rock-chips.com> <20141015130452.GD27755@sirena.org.uk> <543F8CD2.1010302@rock-chips.com> <20141016093410.GB2200@sirena.org.uk> <543F96DB.40403@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3O1VwFp74L81IIeR" Content-Disposition: inline In-Reply-To: <543F96DB.40403@rock-chips.com> X-Cookie: Is this really happening? User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 62.156.150.204 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] spi/rockchip: fix bug that case spi can't go as fast as slave request X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3O1VwFp74L81IIeR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 16, 2014 at 05:58:51PM +0800, addy ke wrote: Please fix your mailer to word wrap within paragraphs. > On 2014/10/16 17:34, Mark Brown wrote: > >> If we set the rate unconditionally here, clk_set_rate() will be executed in each spi transfer. > > Is that really such a high cost? > Not high cost, but I think if the default spi_clk is enough, we do not need to set spi_clk again. > Maybe we can only set spi_clk as (2 * MAX_SCLK_OUT) in probe(). It's not too bad to do it where it is, it just seems better to be simpler. --3O1VwFp74L81IIeR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUP51bAAoJECTWi3JdVIfQsqUIAIBGJkL6Jkve/Hu047z7xaaz iNtIkYoYq8em30yzbYyH2YKXog+D4HRng6bR1rI/Pil0bfPliYMFiHJBz3l3XfrO TgNcyZE3Lm1CWOOuADLmmvtzz+z70tSXJRVPPplFPXU9OQrZBdzo3ZRSMMOyzXfl UFMIndIcr0A6hDkPNsldHLrpkVitI7ceZjG86nDu/uPtqQRj1Nzl0J67w5EzmNLN oByideJoYAv0oYWnUHe/EPpRQz7JYlilZ5DoCpNUP0HKWeYhtgU51r37vzB5glg0 SyUHKqp94ysx3ZDsUMm9pSUvQz3y8KJxj8wiszqkbnw4Nohz2f+B3+6UpMoYQn0= =9p8j -----END PGP SIGNATURE----- --3O1VwFp74L81IIeR-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/