Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbaJPNol (ORCPT ); Thu, 16 Oct 2014 09:44:41 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42938 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbaJPNok (ORCPT ); Thu, 16 Oct 2014 09:44:40 -0400 X-Originating-IP: 62.156.150.204 Date: Thu, 16 Oct 2014 15:44:30 +0200 From: Josh Triplett To: Aristeu Rozanski Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Johannes Berg Subject: Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Message-ID: <20141016134430.GB7664@thin> References: <20141016133658.GP5930@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141016133658.GP5930@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 16, 2014 at 09:36:58AM -0400, Aristeu Rozanski wrote: > (This time Cc'ing Johannes) This kind of note shouldn't be in the commit-message portion of the commit. > It's desirable for allnconfig and tinyconfig targets to result in the > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to > switch off DEV_COREDUMP regardless if any drivers select > WANT_DEV_COREDUMP. > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > 'n' (as in allnconfig or tinyconfig) will effectively disable device > coredump. > > Cc: Greg Kroah-Hartman > Cc: Josh Triplett > Cc: Johannes Berg > Reviewed-by: Josh Triplett > Signed-off-by: Aristeu Rozanski You should have a "---" line here, followed by a diffstat. If you're not using git format-patch to format your patches, you should. - Josh Triplett > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 134f763..99d3072 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP > Drivers should "select" this option if they desire to use the > device coredump mechanism. > > -config DISABLE_DEV_COREDUMP > - bool "Disable device coredump" if EXPERT > +config ENABLE_DEV_COREDUMP > + bool "Enable device coredump" if EXPERT > + default y > help > - Disable the device coredump mechanism despite drivers wanting to > - use it; this allows for more sensitive systems or systems that > - don't want to ever access the information to not have the code, > - nor keep any data. > + This option controls if the device coredump mechanism is available or > + not; if disabled, the mechanism will be omitted even if drivers that > + can use it are enabled. > + Say 'N' for more sensitive systems or systems that don't want > + to ever access the information to not have the code, nor keep any > + data. > > - If unsure, say N. > + If unsure, say Y. > > config DEV_COREDUMP > bool > default y if WANT_DEV_COREDUMP > - depends on !DISABLE_DEV_COREDUMP > + depends on ENABLE_DEV_COREDUMP > > config DEBUG_DRIVER > bool "Driver Core verbose debug messages" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/