Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbaJPOBT (ORCPT ); Thu, 16 Oct 2014 10:01:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48224 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbaJPOBR (ORCPT ); Thu, 16 Oct 2014 10:01:17 -0400 Date: Thu, 16 Oct 2014 16:01:16 +0200 Message-ID: From: Takashi Iwai To: Shuah Khan Cc: Lars-Peter Clausen , m.chehab@samsung.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com, dheitmueller@kernellabs.com, hverkuil@xs4all.nl, ramakrmu@cisco.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, perex@perex.cz, prabhakar.csengg@gmail.com, tim.gardner@canonical.com, linux@eikelenboom.it, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api In-Reply-To: <543FC3CD.8050805@osg.samsung.com> References: <543FB374.8020604@metafoo.de> <543FC3CD.8050805@osg.samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 16 Oct 2014 07:10:37 -0600, Shuah Khan wrote: > > On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: > > On 10/14/2014 04:58 PM, Shuah Khan wrote: > > [...] > >> switch (cmd) { > >> case SNDRV_PCM_TRIGGER_START: > >> + err = media_get_audio_tkn(&subs->dev->dev); > >> + if (err == -EBUSY) { > >> + dev_info(&subs->dev->dev, "%s device is busy\n", > >> + __func__); > > > > In my opinion this should not dev_info() as this is out of band error > > signaling and also as the potential to spam the log. The userspace > > application is already properly notified by the return code. > > > > Yes it has the potential to flood the dmesg especially with alsa, > I will remove the dev_info(). Yes. And, I think doing this in the trigger isn't the best. Why not in open & close? Also, is this token restriction needed only for PCM? No mixer or other controls? Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/