Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753107AbaJPOK5 (ORCPT ); Thu, 16 Oct 2014 10:10:57 -0400 Received: from lists.s-osg.org ([54.187.51.154]:40901 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbaJPOK4 (ORCPT ); Thu, 16 Oct 2014 10:10:56 -0400 Message-ID: <543FD1EC.5010206@osg.samsung.com> Date: Thu, 16 Oct 2014 08:10:52 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Takashi Iwai CC: Lars-Peter Clausen , m.chehab@samsung.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, crope@iki.fi, olebowle@gmx.com, dheitmueller@kernellabs.com, hverkuil@xs4all.nl, ramakrmu@cisco.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, perex@perex.cz, prabhakar.csengg@gmail.com, tim.gardner@canonical.com, linux@eikelenboom.it, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api References: <543FB374.8020604@metafoo.de> <543FC3CD.8050805@osg.samsung.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2014 08:01 AM, Takashi Iwai wrote: > At Thu, 16 Oct 2014 07:10:37 -0600, > Shuah Khan wrote: >> >> On 10/16/2014 06:00 AM, Lars-Peter Clausen wrote: >>> On 10/14/2014 04:58 PM, Shuah Khan wrote: >>> [...] >>>> switch (cmd) { >>>> case SNDRV_PCM_TRIGGER_START: >>>> + err = media_get_audio_tkn(&subs->dev->dev); >>>> + if (err == -EBUSY) { >>>> + dev_info(&subs->dev->dev, "%s device is busy\n", >>>> + __func__); >>> >>> In my opinion this should not dev_info() as this is out of band error >>> signaling and also as the potential to spam the log. The userspace >>> application is already properly notified by the return code. >>> >> >> Yes it has the potential to flood the dmesg especially with alsa, >> I will remove the dev_info(). > > Yes. And, I think doing this in the trigger isn't the best. > Why not in open & close? My first cut of this change was in open and close. I saw pulseaudio application go into this loop trying to open the device. To avoid such problems, I went with trigger stat and stop. That made all the pulseaudio continues attempts to open problems go away. > > Also, is this token restriction needed only for PCM? No mixer or > other controls? snd_pcm_ops are the only ones media drivers implement and use. So I don't think mixer is needed. If it is needed, it is not to hard to add for that case. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/