Message-ID: <1413470763.6702.3.camel@perches.com>
Subject: Re: [PATCH] kernel:module Fix coding style errors and warnings.
From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Ionut Alexa <ionut.m.alexa@gmail.com>, rusty@rustcorp.com.au,
        linux-kernel@vger.kernel.org
Date: Thu, 16 Oct 2014 07:46:03 -0700
In-Reply-To: <20141016125724.GA5244@sudip-PC>
References: <1413452213-27450-1-git-send-email-ionut.m.alexa@gmail.com>
	 <1413452333.6702.1.camel@perches.com> <20141016125724.GA5244@sudip-PC>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 2014-10-16 at 18:27 +0530, Sudip Mukherjee wrote:
> On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote:
> > On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
> > > Fixed codin style errors and warnings. Changes printk with
> > > print_debug/warn. Changed seq_printf to seq_puts.
> > If you are going to do style cleanups, please make
> > sure you check your patches with scripts/checkpatch.pl
> > before sending them.
[]
> should we be doing style cleanups in the kernel files ?

Generally, no.

> previously i saw comments discouraging it as it pollutes the git blame.

Also generally, style only patches are discouraged
but can be done as part of a series when enhancements,
bug-fixes or optimizations are done.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/